[Snyk] Security upgrade python from 3.13.7-slim to 3.14.2-slim #19
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-DEBIAN13-OPENSSL-13174592 - https://snyk.io/vuln/SNYK-DEBIAN13-OPENSSL-13174592 - https://snyk.io/vuln/SNYK-DEBIAN13-OPENSSL-13174602 - https://snyk.io/vuln/SNYK-DEBIAN13-OPENSSL-13174605 - https://snyk.io/vuln/SNYK-DEBIAN13-OPENSSL-13174605
Summary of ChangesHello @doublegate, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, focuses on improving the security of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request, automatically generated by Snyk, upgrades the Python base image from 3.13.7-slim to 3.14.2-slim in the services/arms/retriever/Dockerfile to fix security vulnerabilities. While this is a necessary security update, the change as-is will break the Docker build due to a hardcoded path for Python's site-packages directory. A critical review comment has been added to highlight this issue and provide a solution to ensure the build succeeds with the new Python version.
| # syntax=docker/dockerfile:1 | ||
| # Retriever Arm Dockerfile - Multi-stage build for Python service | ||
| FROM python:3.13.7-slim as builder | ||
| FROM python:3.14.2-slim as builder |
There was a problem hiding this comment.
This upgrade to Python 3.14 will cause the Docker build to fail. The COPY instruction on line 41, which copies packages from the builder stage to the runtime stage, has a hardcoded path for Python 3.13.
# line 41
COPY --from=builder /usr/local/lib/python3.13/site-packages /usr/local/lib/python3.13/site-packagesBecause both the builder stage (updated here on line 3) and the runtime stage (updated on line 26) now use Python 3.14, this path is incorrect for both the source and destination. The build will fail with a 'file not found' error.
To fix this, line 41 must be updated to use the Python 3.14 path:
COPY --from=builder /usr/local/lib/python3.14/site-packages /usr/local/lib/python3.14/site-packagesTo make this file more robust for future upgrades, I recommend using a build argument to define the Python version and using it to construct the path, avoiding hardcoded version numbers.
There was a problem hiding this comment.
Pull request overview
This PR attempts to upgrade the Python base image from 3.13.7-slim to 3.14.2-slim to address security vulnerabilities in OpenSSL dependencies. However, there is a critical issue with this upgrade.
- Upgrades Python base image from 3.13.7-slim to 3.14.2-slim
- Updates both builder and runtime stages in the multi-stage Docker build
- Aims to fix 3 low-severity CVEs related to OpenSSL
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Snyk has created this PR to fix 3 vulnerabilities in the dockerfile dependencies of this project.
Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Snyk changed the following file(s):
services/arms/retriever/DockerfileWe recommend upgrading to
python:3.14.2-slim, as this image has only 23 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.Vulnerabilities that will be fixed with an upgrade:
SNYK-DEBIAN13-OPENSSL-13174592
SNYK-DEBIAN13-OPENSSL-13174592
SNYK-DEBIAN13-OPENSSL-13174602
SNYK-DEBIAN13-OPENSSL-13174605
SNYK-DEBIAN13-OPENSSL-13174605
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.